server/comms: add new routes to limiter #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the newish price feed, spots, and candles to the routeLimiter. The "info" limiter includes the spots and candles routes. A new shared limiter for subscription routes is created for the order_book and the new price_feed routes. Add the connect route with its own rates. Burst is still 100. Clients should self limit during account discover, as we do.
buck54321
reviewed
Nov 18, 2021
server/comms/server.go
Outdated
| wsRateRegister, wsBurstRegister = 1 / 60.0, 1 // register, rate.Every(time.Minute) but const | ||
| wsRateConnect, wsBurstConnect = 4, 100 // connect, account discovery requires bursts - (*Core).discoverAccount |
There was a problem hiding this comment.
Wouldn't the extra connections just use some of the burst tokens? A constant rate of 4 connections per second seems really high. What would be the harm in going lower, maybe 1 / 10.0 ?
In general, these rates seem pretty permissive.
There was a problem hiding this comment.
That's a good point re the connect route. I agree.
I've tried to be cautious about the limits so we don't dos people too easily, but this one in particular really has no good case for sustained 4 per second. Will update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the newish price feed, spots, and candles to the
routeLimiter.The "info" limiter includes the spots and candles routes.
A new shared limiter for subscription routes is created for the
order_bookand the newprice_feedroutes.Add the connect route with its own rates. Burst is still 100. Clients should self limit during account discover, as we do.