client/asset/eth: fix client balance calcs #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client apparently doesn't maintain a pending state, so the way I had calculated balance client-side didn't work. Go going back to martonp's initial implementation which parses redeem and refund data from transactions. Remove the Pending field from Balance. It wasn't used.
buck54321
commented
Dec 1, 2021
chappjc
reviewed
Dec 1, 2021
|
Mostly unrelated to this PR, but there are a lot of unused Context args to |
martonp
reviewed
Dec 3, 2021
These methods are thin wrappers anyway.
buck54321
force-pushed
the
eth-client-fee-again
branch
from
e34f69d
to
8990129
Compare
JoeGruffins
approved these changes
Dec 6, 2021
chappjc
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client apparently doesn't maintain a pending state, so the
way I had calculated balance client-side didn't work. Go back
to @martonp's initial implementation which parses redeem
and refund data from transactions.
Remove the
Pendingfield fromBalance. It wasn't used.