[release-v0.4] dex/keygen: use ChildBIP32Std for extended key derivation #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Dec 15, 2021
buck54321
approved these changes
Dec 17, 2021
This updates the GenDeepChild helper, which is used in both client/core to setup DEX account keys from the app seed, and in client/asset/eth to derive the account private key from the wallet seed. This is especially in the eth key derivation, where the intent is to follow BIP44 with the path m/44'/60'/0'/0/0, which requires generating child keys as per BIP32 strictly. For generating DEX account keys from the app seed, it is also good from a standardness point of view to use strict BIP32 derivation. The legacy derivation is only required for Decred wallets for compatibility.
chappjc
force-pushed
the
bip32std-child-0-4
branch
from
c0e6e1c
to
6fbfa89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1341 for the
release-v0.4branch.Requires #1349, which updates the go.mods first.
Updates the
github.com/decred/dcrd/hdkeychain/v3require to v3.1.0.WARNING: Keys derived from the app seed are likely to be different with the updated strict BIP32 HD key derivation. This includes
Wallets such as inclient/asset/ethwhere it prepares a private key for the BIP44 path m/44'/60'/0'/0/0As such, you should not rely on any of these accounts or keys being recoverable.
This updates the
GenDeepChildhelper, which is used in both client/core to setup DEX account keys from the app seed, and in client/asset/eth to derive the account private key from the wallet seed.This is especially in the eth key derivation, where the intent is to follow BIP44 with the path m/44'/60'/0'/0/0, which requires generating child keys as per BIP32 strictly.
For generating DEX account keys from the app seed, it is also good from a standardness point of view to use strict BIP32 derivation. The legacy derivation is only required for Decred wallets for compatibility.
Resolves #1337
This eliminates the occasional error from
client/asset/eth.CreateWallet