Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DE translations #1815

Merged
merged 1 commit into from Aug 30, 2022
Merged

add DE translations #1815

merged 1 commit into from Aug 30, 2022

Conversation

karamble
Copy link
Member

this adds translations for the latest release-v0.5 branch strings and adds the language to locales.go

@chappjc chappjc added this to the 0.5.1 milestone Aug 23, 2022
@chappjc
Copy link
Member

chappjc commented Aug 23, 2022

Awesome, thanks! We're chatting on Matrix, but echoing some things here for future reference:

https://github.com/decred/dcrdex/wiki/Localization-and-Translation
There are currently three different scopes that need translated strings: Go (notifications), html (static page components), js (live page stuff)

Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Although we're getting rid of localized_html in #1826, merging now so it can be applied cleanly to a 0.5 patch.

@chappjc chappjc changed the base branch from release-v0.5 to master August 30, 2022 21:10
@chappjc chappjc changed the base branch from master to release-v0.5 August 30, 2022 21:12
@chappjc chappjc merged commit d8c6ce3 into decred:release-v0.5 Aug 30, 2022
@chappjc chappjc mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants