Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcrdex Ar #1844

Closed
wants to merge 8 commits into from
Closed

dcrdex Ar #1844

wants to merge 8 commits into from

Conversation

Insaf01
Copy link

@Insaf01 Insaf01 commented Sep 14, 2022

No description provided.

@chappjc
Copy link
Member

chappjc commented Sep 14, 2022

Thanks @Insaf01! This mostly covers step 1 (HTML strings) described https://github.com/decred/dcrdex/wiki/Localization-and-Translation

For the other two language domains with translated strings:

Sorry to have the translations in three different spots. We'll eventually simplify that, but it's a challenge.

@Insaf01
Copy link
Author

Insaf01 commented Oct 5, 2022

Thank you @chappjc, sorry for the late reply, I've add the translation for the two other files

@chappjc
Copy link
Member

chappjc commented Oct 6, 2022

Thank you @chappjc, sorry for the late reply, I've add the translation for the two other files

Can you check your git workspace? This branch doesn't include changes to the other two files. https://github.com/decred/dcrdex/pull/1844/files

@chappjc
Copy link
Member

chappjc commented Oct 11, 2022

Thanks @Insaf01. I'm going to put these changes on a different branch and open a new PR with some minor changes. I think this is everything that's needed.

@chappjc
Copy link
Member

chappjc commented Oct 11, 2022

All set. Rebased and squashed into #1898. You've done all the hard work @Insaf01 and you're the git commit is yours in that PR. I'll just have to tweak as needed so it builds and runs as intended. I'll message you if there's anything else to add.

@chappjc chappjc closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants