client/db: add account backup and restore. #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
Mar 20, 2020
buck54321
requested changes
Mar 20, 2020
There was a problem hiding this comment.
This is almost exactly what I had in mind, but I do want to standardize this format at the level of the client/db package. So probably a type dexdb.AccountBackup which has a Serialize() []byte method. This ensures that the backup can be imported into a different database backend in the future.
dnldd
changed the title
chappjc
reviewed
Mar 23, 2020
chappjc
requested changes
Mar 24, 2020
There was a problem hiding this comment.
Just a small tweak for me. @buck54321 might have other suggestions.
Also, please try not to squash commits during review. Even after the PR is approved it's not necessary to squash since I just do it. Review is way easier if we see all the incremental diffs.
This adds AccountBackup type for backup and restore functionality for user accounts. RandomWallet has also been updated to use the current time for balance update times to fix an issue with TestWallets.
chappjc
approved these changes
Mar 24, 2020
buck54321
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
AccountBackuptype for backup and restore functionality for user accounts.RandomWallethas also been updated to use the current time for balance update times to fix an issue withTestWallets.Resolves #179.