New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: rework app initialization #2385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @buck54321. I will try testing this on my end.
Very nice. Wallets above servers would be better for the multi-coin wallet pivot, but this is great either way. |
Getting the same error as cli when trying to use:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the issues which @JoeGruffins also noticed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working very well for me with the last commit. Just some thoughts--
When you choose only to add wallets, no DEX host, we could add a link like this on the wallets page:
But that's not a new issue and not necessary. It could just be a plain <a href="/register">
The other thing, which is think is just a design decision, is when you add a DEX using this new interface, it's always "view-only" even if you had already had an account. We assume no account discovery by default is desirable. Should we? I restored from seed where I already had an account, and I saw:
And clicking discovered it so I got this simple form:
A slightly different approach that would avoid the need to add a "view-only" checkbox on this simplified init flow would be to first try assuming you want to discover an account, and then fall back to view-only if there was no known account. I don't think backend changes are needed for this.
Anyway, no need to make any changes. It works as-is! Thoughts? We can merge if there's no need to update in your mind.
Pls squash/rebase and we can merge. |
This reworks app initialization to achieve a number of ux goals. 1) Adds chance for user to quickly configure native wallets and add known dexes (view-only) 2) Adds seed backup dialog 3) Makes the Wallets view the landing page
Rebased and squashed for you so we can merge this since it has been good with approvals for a while. |
This reworks app initialization to achieve a number of ux goals.
known servers (view-only), client: allow skipping registration when adding a dex (view-only) #1986 (comment)