testing/loadbot: Add moving markets. #2409

JoeGruffins · 2023-06-21T14:03:21Z

part of #2303

Add several tools to the loadbot to allow for sideways, trending, and volatile markets. Remove most mining as continuous mining is provided by the harnesses themselves, and this allows us to run multiple bots at once without excessive mining.

To allow for sideways and trending markets, new options for the sidestacker can be used. These are a flat increase to the rate or an automatic oscillating effect. Volatile markets can be achieved by running the ts bot separately that randomly buys, or sells, large sums moving the market violently.

The sideways market after running a bit.

JoeGruffins · 2023-06-21T14:06:50Z

I am having a lot of trouble keeping the dcr market up while using bots. The harness freezes randomly and there's nothing to do. "something something already discreet mining". This is not a new problem and not sure the cause. So, testing on a btc/eth market mostly at the moment.

martonp · 2023-06-24T07:39:47Z

Haven't reviewed yet, but I've been testing with oscillate, and it's working nicely!

One thing I noticed is that it seems like it will only match orders on one side of the market for ~30 mins, then only the other side for ~30 mins. I think it would be more natural if even if it's trending in one direction, it would still ocassionally match orders in the other. Perhaps there could be a random number generated, and when the market is trending up, 75% of the time the bots would place a higher order and only 25% place a lower one, or something to that effect?

Another helpful option would be to have it stay near a certain price an oscillate in a tighter range around that. This price could be either specified by the user, or it actual current market prices could be queried. This would be helpful because the bots actually use market prices in addition to looking at the order book to make decisions.

JoeGruffins · 2023-06-26T11:24:35Z

Added three new settings for the sidestacker: "randomosc", "oscinterval", and "oscstep". I hope these can add enough control to get the kind of sideways market one may want. Watching randomosc atm so see if it looks sort of natural.

JoeGruffins · 2023-06-26T13:28:12Z

Seems like theres a bit too many standing orders accumulating. Maybe should cancel more.

JoeGruffins · 2023-06-29T08:58:33Z

random oscillating:

random oscillating with ts:
Two separate bots.

./loadbot -p sidestacker -mkt btc_eth -oscillate -ignoreerrors -trace -randomosc
./loadbot -p ts -mkt btc_eth -trace -ignoreerrors

client/webserver/site/package-lock.json

dex/testing/loadbot/README.md

chappjc · 2023-07-10T20:59:52Z

dex/testing/loadbot/compound.go

@@ -13,17 +13,16 @@ import (
 // runCompound runs the 'compound' program, consisting of 2 (5/3) unmetered
 // sideStackers, a 1-order sniper, and a pingPonger.
 func runCompound() {
-	go blockEvery2()


-- because we have miners in tmux? Makes sense, but the doge and dgb harnesses are missing miner windows. I'll make a separate issue so it doesn't hold up this PR.

Yeah, the one block per 15 min should be sufficient. Leaving it to the harnesses so multiple bots can be run without over mining, especially since this seems to be where the dcr harness gets stuck, with mining calls happening concurrently.

I'll add, should only be a few lines each. Sorry for missing that, I assumed they all had miners now.

dgb was turned off, I wonder if intentional?

dgb was turned off, I wonder if intentional?

Don't recall. @dev-warrior777 is turning it back on in another PR it looks like.

Yes, but dgb will never work very well for regtest mining until dgb 8.x series which is on RC2 right now and coming to RC3 soon I am assured.

For 8.x they have a new parameter for the daemon which addresses the regtest mining weakness specifically.

Oh duh that's why I disabled it. I even talked to their devs about it. easypow

easypow correct
I tested it today doing many loops mining 100 blocks a time.

Oh yeah, conflicts with @dev-warrior777 If that goes in first I will rebase over it.

dex/testing/loadbot/sidestacker.go

dex/testing/loadbot/loadbot.go

JoeGruffins · 2023-07-11T06:50:33Z

Mostly attempting to clear up comments and variable names https://github.com/decred/dcrdex/compare/87e98c81397fc4aee1ef09ce5dcb4d5e35d54597..3045223166d7d081d99d47ee7538447ed183f401

JoeGruffins · 2023-07-12T01:56:43Z

active -> oscillatorWrite and matching error strings for cancel orders
https://github.com/decred/dcrdex/compare/d6a2f46240ee2551c80a35e3f234af9cf3586b52..d746828003d42e65455dc22d04a330837a701e69

chappjc · 2023-07-19T22:03:11Z

dex/testing/dgb/harness.sh

+
+# Background watch mining by default:
+# 'export NOMINER="1"' or uncomment this line to disable
+#NOMINER="1"


As per #2434, I think this has to be set for DGB since their release version cannot mine indefinitely in simnet and it ends up grinding CPU endlessly.

When running loadbot, we'll just have to start a miner manually. Maybe we can echo something here as a reminder to the dev.

Uncommented and left a TODO

chappjc · 2023-07-19T22:04:43Z

dex/testing/doge/harness.sh

@@ -273,6 +277,8 @@ tmux send-keys -t $SESSION:0 C-c
 tmux send-keys -t $SESSION:1 C-c
 tmux send-keys -t $SESSION:2 C-c
 tmux send-keys -t $SESSION:3 C-c
+tmux send-keys -t $SESSION:4 C-c


This tries to kill the quit script itself. A few lines down it will remove the ctl session using tmux kill-session.

Removed this ctrl-c.

JoeGruffins · 2023-07-20T03:50:13Z

Apologies rebased onto master with those changes so cannot get a clean diff on github I think. Was two changes in the harnesses

diff

diff --git a/dex/testing/dgb/harness.sh b/dex/testing/dgb/harness.sh
index 6e90e949..5de493b1 100755
--- a/dex/testing/dgb/harness.sh
+++ b/dex/testing/dgb/harness.sh
@@ -27,7 +27,10 @@ export EXTRA_ARGS="-disabledandelion=1 -rpcbind=0.0.0.0 -rpcallowip=0.0.0.0/0 -n
 
 # Background watch mining by default:
 # 'export NOMINER="1"' or uncomment this line to disable
-#NOMINER="1"
+#
+# TODO: Cannot presently continuously mine on simnet but when we can comment
+# this out.
+NOMINER="1"
 
 # Run the harness
 ../btc/base-harness.sh
diff --git a/dex/testing/doge/harness.sh b/dex/testing/doge/harness.sh
index e84689e5..6292178b 100755
--- a/dex/testing/doge/harness.sh
+++ b/dex/testing/doge/harness.sh
@@ -277,7 +277,6 @@ tmux send-keys -t $SESSION:0 C-c
 tmux send-keys -t $SESSION:1 C-c
 tmux send-keys -t $SESSION:2 C-c
 tmux send-keys -t $SESSION:3 C-c
-tmux send-keys -t $SESSION:4 C-c
 tmux send-keys -t $SESSION:5 C-c
 tmux wait-for alpha${SYMBOL}
 tmux wait-for beta${SYMBOL}

dev-warrior777 · 2023-07-20T05:47:14Z

Apologies rebased onto master with those changes so cannot get a clean diff on github I think. Was two changes in the harnesses

Was my bad initially I guess ;-(

JoeGruffins · 2023-07-21T01:54:29Z

Was my bad initially I guess

Lets not git blame (joke)

JoeGruffins · 2023-07-22T06:14:00Z

ts -> whale and making whale percent settable https://github.com/decred/dcrdex/compare/f81b00933a83673f709d4d24de30c9128d2f4836..4cfa8d20b831e4a3f440e1efd8b549e892b38dc9

JoeGruffins · 2023-07-22T12:06:15Z

The sidestaker seems to be requesting way too much eth. Something doesn't look right. Investigating...

JoeGruffins · 2023-07-24T04:42:21Z

Requesting too much fixed https://github.com/decred/dcrdex/compare/83634d296e655d4cfb59460038b72491a6315420..52e52eba7fcb1a8e3cd49c87de89dc66842b21c8

JoeGruffins · 2023-07-24T07:47:06Z

$ ./loadbot -p sidestacker -mkt btc_eth -oscillate -ignoreerrors -trace -randomosc
and
$ ./loadbot -p whale -whalepercent 0.5 -mkt btc_eth -ignoreerrors

The first bot was suspended for something eventually...

2023-07-24 16:19:15.296 [WRN] CORE:STACKER:0: notify: |WARNING| (notify) Server has penalized you - Penalty from DEX at 127.0.0.1:17273
last broken rule: CancellationRate
time: 2023-07-24 16:19:15.268 +0900 JST
details:
"Ordering has been suspended for this account. Post additional bond to offset violations.
Last Broken Rule Details: cancellation rate dropped below the acceptable level
excessive cancellation rate, new tier = 0"

Should do something to prevent this?

dev-warrior777 · 2023-07-24T09:45:53Z

""Ordering has been suspended for this account. Post additional bond to offset violations."

..you are a Whale .. pay up out of the slush fund ;-)

JoeGruffins · 2023-07-25T14:11:44Z

I guess setting bond target tier to 1 should keep us trading automatically?

JoeGruffins · 2023-07-26T07:58:48Z

Now posting bond instead of registering, which should set the tier to 1 so it will automatically keep us un-banned. Right? https://github.com/decred/dcrdex/compare/52e52eba7fcb1a8e3cd49c87de89dc66842b21c8..3cbca47a8dd11f3d1279bbe7059912a6d3d47140

JoeGruffins · 2023-07-28T08:15:50Z

Maybe better if the bots don't get banned for cancels, going to try to avoid canceling orders created one epoch ago.

JoeGruffins · 2023-07-28T10:11:51Z

Hmm, starting the server does say:

2023-07-28 15:01:47.632 [INF] DEX: Cancellations are NOT COUNTED (the cancellation rate threshold is ignored).

buck54321 · 2023-07-28T12:56:17Z

We really shouldn't be using freecancels for load testing. Something like this would prepare sidestacker for turning of freecancels.

JoeGruffins · 2023-07-31T02:47:59Z

We really shouldn't be using freecancels for load testing. Something like this would prepare sidestacker for turning of freecancels.

Thanks! I had the same changes waiting to go but was looking at the issue of the clients not remaining bonded.

JoeGruffins · 2023-08-04T08:38:24Z

Don't cancel orders within the last epoch https://github.com/decred/dcrdex/compare/96352ac9ea83daa86d0944f8d2d55d82da77be26..7502d0fa94756aa97498f13b77a3a15d6bdff677

buck54321 · 2023-08-09T04:44:20Z

@JoeGruffins could you please test on top of the newest version of #2449 and confirm that the bug is resolved.

JoeGruffins · 2023-08-09T07:04:33Z

@buck54321 the "ghost orders" appear to be gone!

buck54321 · 2023-08-11T06:26:12Z

Can rebase now that #2449 is in. Could also try removing freecancels=1 from the server simnet harness config.

Add several tools to the loadbot to allow for sideways, trending, and volatile markets. Remove most mining as continuous mining is provided by the harnesses themselves, and this allows us to run multiple bots at once without excessive mining. To allow for sideways and trending markets, new options for the sidestacker can be used. These are a flat increase to the rate or an automatic oscillating effect. Volatile markets can be achieved by running the whale bot separately that randomly buys, or sells, large sums moving the market violently.

JoeGruffins · 2023-08-14T02:58:05Z

Rebased. Also turning off free cancels https://github.com/decred/dcrdex/compare/b0ab65b8f359efd3fdda70c97e127c0242ad195a..21398e76284b82259f5d60f862819547073bede6

martonp mentioned this pull request Jun 25, 2023

client/{core, btc}: MultiTrade #2362

Merged

JoeGruffins force-pushed the addloadbotprograms branch from 18ef042 to f597a06 Compare June 26, 2023 11:17

JoeGruffins force-pushed the addloadbotprograms branch 4 times, most recently from ac561c6 to 19fc8fc Compare June 29, 2023 08:52

JoeGruffins force-pushed the addloadbotprograms branch 2 times, most recently from 0c45ba0 to 6ae6d3e Compare June 29, 2023 12:28

JoeGruffins marked this pull request as ready for review June 29, 2023 12:28

JoeGruffins mentioned this pull request Jul 1, 2023

loadbot: Add live price oracles. #2420

Merged

chappjc requested changes Jul 10, 2023

View reviewed changes

JoeGruffins force-pushed the addloadbotprograms branch 2 times, most recently from 87e98c8 to 3045223 Compare July 11, 2023 06:49

JoeGruffins force-pushed the addloadbotprograms branch 3 times, most recently from d6a2f46 to d746828 Compare July 12, 2023 01:51

chappjc reviewed Jul 19, 2023

View reviewed changes

JoeGruffins force-pushed the addloadbotprograms branch from d746828 to 950c02c Compare July 20, 2023 03:44

JoeGruffins force-pushed the addloadbotprograms branch from 950c02c to 0b474b4 Compare July 21, 2023 02:02

JoeGruffins force-pushed the addloadbotprograms branch from 4cfa8d2 to 83634d2 Compare July 22, 2023 06:19

JoeGruffins force-pushed the addloadbotprograms branch from 83634d2 to 52e52eb Compare July 24, 2023 04:39

JoeGruffins force-pushed the addloadbotprograms branch from 52e52eb to 3cbca47 Compare July 26, 2023 07:55

JoeGruffins force-pushed the addloadbotprograms branch from 3cbca47 to e49ef5c Compare July 28, 2023 08:08

JoeGruffins mentioned this pull request Aug 4, 2023

bonds: Users with a good server score do not stay bonded. #2459

Closed

JoeGruffins force-pushed the addloadbotprograms branch 2 times, most recently from 96352ac to 7502d0f Compare August 4, 2023 08:37

JoeGruffins force-pushed the addloadbotprograms branch from 7502d0f to f9b2ef0 Compare August 9, 2023 05:03

JoeGruffins force-pushed the addloadbotprograms branch from f9b2ef0 to b0ab65b Compare August 14, 2023 02:27

JoeGruffins force-pushed the addloadbotprograms branch from b0ab65b to 21398e7 Compare August 14, 2023 02:57

buck54321 mentioned this pull request Aug 15, 2023

client/mm: Update Basic Market Maker #2416

Merged

buck54321 approved these changes Aug 25, 2023

View reviewed changes

buck54321 merged commit 8fad253 into decred:master Aug 25, 2023
5 checks passed

testing/loadbot: Add moving markets. #2409

testing/loadbot: Add moving markets. #2409

Conversation

JoeGruffins commented Jun 21, 2023 • edited

JoeGruffins commented Jun 21, 2023

martonp commented Jun 24, 2023

JoeGruffins commented Jun 26, 2023

JoeGruffins commented Jun 26, 2023

JoeGruffins commented Jun 29, 2023 • edited

Choose a reason for hiding this comment

JoeGruffins Jul 11, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc Jul 12, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented Jul 11, 2023

JoeGruffins commented Jul 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented Jul 20, 2023

dev-warrior777 commented Jul 20, 2023

JoeGruffins commented Jul 21, 2023 • edited

JoeGruffins commented Jul 22, 2023

JoeGruffins commented Jul 22, 2023

JoeGruffins commented Jul 24, 2023

JoeGruffins commented Jul 24, 2023 • edited

dev-warrior777 commented Jul 24, 2023

JoeGruffins commented Jul 25, 2023

JoeGruffins commented Jul 26, 2023

JoeGruffins commented Jul 28, 2023

JoeGruffins commented Jul 28, 2023

buck54321 commented Jul 28, 2023

JoeGruffins commented Jul 31, 2023

JoeGruffins commented Aug 4, 2023

buck54321 commented Aug 9, 2023

JoeGruffins commented Aug 9, 2023

buck54321 commented Aug 11, 2023

JoeGruffins commented Aug 14, 2023

JoeGruffins commented Jun 21, 2023 •

edited

JoeGruffins commented Jun 29, 2023 •

edited

JoeGruffins Jul 11, 2023 •

edited

chappjc Jul 12, 2023 •

edited

JoeGruffins commented Jul 21, 2023 •

edited

JoeGruffins commented Jul 24, 2023 •

edited