dexc-desktop: Implement native notifications for MacOS #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
force-pushed
the
macos-notifications
branch
from
397fb18
to
fe796de
Compare
|
Just need a rebase. |
|
I merged the rebrand, so the rebase looks scary, but it's really nothing. |
Oh okay, will get to it soon. |
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
ukane-philemon
force-pushed
the
macos-notifications
branch
from
003b00b
to
a9909a8
Compare
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
ukane-philemon
force-pushed
the
macos-notifications
branch
from
a9909a8
to
7a4f8c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2674.
The first time we send a notification, the user has to
Allowthe app to continue sending notifications, but if they deny the app, they can allow notification later in their app settings.Tested on Ventura 13.6.6.
Notification Settings
