admin: Add Accounts. #441
Merged
admin: Add Accounts. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
requested changes
Jun 4, 2020
In order to view account data in the database, add an api enpoint to the admin server that retrieves all accounts and returns a slice of accounts. Byte arrays are encoded in hex for readability.
JoeGruffins
force-pushed
the
adminaccounts
branch
3 times, most recently
from
890a91e
to
817e827
Compare
chappjc
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Looks good and working:
$ dexadm accounts
[
{
"accountid": "93e6566e0c4c5c3ac03514fe532f494a7a71b392031c462087bb8c511d532149",
"pubkey": "0282c421175228136a9f9ed42e7fa63ce4f33900eca27ea1d4675c56e8675b01bf",
"feeaddress": "SsonWQK6xkLSYm7VttCddHWkWWhETFMdR4Y",
"feecoin": "f680451275ce09feecb9cc21d829e6e5eeb966dc2c57360f91696ac80742e88a00000000",
"brokenrule": 0
}
]
Suggestions for future work:
- and endpoint
account/{accountid} - active order count (just the count) and active swaps list (match IDs)
- maybe further details in endpoints like
account/{accountid}/swaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to view account data in the database, add an api enpoint to the
admin server that retrieves all accounts and returns a slice of
accounts. Byte arrays are encoded in hex for readability.
part of #329