-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: fix markets view layout issues #560
Conversation
Fixes issues where overflow and div sizing were acting weird on resize. Creates and uses a stylish scrollbar class. Enables manual chart div resizing and remembers the user's preference across sessions. Also correct a recent regression where certain order form elements were not being hidden for market orders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chappjc, I was unable to reproduce the |
I'm not seeing it any more either, at least not with a fresh harness. The one I had with over 1 million DCR was pretty unusual. |
Here's the repro with 1218684.00822222: function str(x){
return x.toLocaleString('en-us', fullPrecisionSpecs);
}
const fullPrecisionSpecs = {
minimumSignificantDigits: 4,
maximumSignificantDigits: 8,
minimumFractionDigits: 8,
maximumFractionDigits: 8
}
let v = 1218684.00822222
var vStr = str(v)
console.log(vStr)
var [whole, frac] = vStr.split('.')
console.log(whole, frac); https://jsbin.com/daqukodoqo/edit?js,console I think |
Fixed |
Fixes issues where overflow and div sizing were acting weird on resize.
Creates and uses a stylish scrollbar class. Enables manual chart div click-drag resizing and remembers the user's preference across sessions.
Also corrects a recent regression where certain order form elements were not being hidden for market orders.
Most of the loc are just html indentation changes. Best tested with the test app server.
resolves #550, #514, #296, #539