Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: allow depth chart zoom up to +/- 100% #573

Merged
merged 2 commits into from Aug 5, 2020
Merged

Conversation

buck54321
Copy link
Member

Zoom was constrained to +/- 50% of the mid-gap rate, but could accommodate double that width without major changes to other parts.

Allowing more is possible, but there are tradeoffs for > 100%, as either a) the charts will need to be reconfigured to allow an off-center mid-gap, or b) the chart will expose a negative scale on the left.

For now, I'm hoping this is an improvement and enough to resolve #553.

@chappjc
Copy link
Member

chappjc commented Jul 30, 2020

Sort of fixes it. I can zoom out more, (but not all the way to get very high/low orders for the reasons you mentioned), but it zooms back in a bit automatically after a moment.

image

moments later:

image

Unlike with the previous random zoom changes, this does not seem to coincide with epoch notes.

@JoeGruffins
Copy link
Member

In my opinion the zoom is enough.

I'm not by any means a good trader, and I don't spend much time looking at charts. Just a normal user. And the exchange I normally use is Binance. I almost exclusively use their mobile app, and their depth map does not zoom very much at all. It really isn't a problem for me.

It would be nice to have the candlesticks graph though, which is probably much more useful for traders to see trends.

However, the zoom does pop back automatically for me too, which is jarring.

@buck54321
Copy link
Member Author

Should be good now. You'll still see the zoom level change ever so slightly if you're at 200% and the mid gap price changes, forcing a re-centering, but that's different. The bug you were seeing is fixed.

@chappjc chappjc merged commit 7731510 into decred:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depth chart needs to zoom out more
3 participants