Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/core: missing matches were incomplete #661

Merged
merged 7 commits into from
Sep 3, 2020

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Sep 2, 2020

Each tracked trade needs to have it's matches checked as missing or not, but it was checked the other way around (each server match is checked against matches for the trades that are reported).

[DBG] CORE: Authenticated connection to 127.0.0.1:7232, 0 active matches
[TRC] CORE: Revoked match 9ad9a6e7feae2ffe8158ce9f182644c39d48a301cca9afc4855ce85b21c59575 (Taker) in status MakerSwapCast considered inactive.
[WRN] CORE: DEX 127.0.0.1:7232 did not report active match 9ad9a6e7feae2ffe8158ce9f182644c39d48a301cca9afc4855ce85b21c59575 on order 9a76f9da8c42f60a0c46d39588a027b08c3833fa4f88f7df8b482b36e5dbb2f1 - assuming revoked.
[ERR] CORE: notify: |ERROR| (order) Missing matches - 1 matches for order 9a76f9da were not reported by "127.0.0.1:7232" and are considered revoked - Order: 9a76f9da8c42f60a0c46d39588a027b08c3833fa4f88f7df8b482b36e5dbb2f1
[WRN] CORE: notify: |WARNING| (order) Match revoked - Match 9ad9a6e7 has been revoked - Order: 9a76f9da8c42f60a0c46d39588a027b08c3833fa4f88f7df8b482b36e5dbb2f1
[WRN] CORE: Match 9ad9a6e7feae2ffe8158ce9f182644c39d48a301cca9afc4855ce85b21c59575 revoked in status MakerSwapCast for order 9a76f9da8c42f60a0c46d39588a027b08c3833fa4f88f7df8b482b36e5dbb2f1
[INF] CORE: Retiring inactive order 40a1d2f4ae94d61627de8ef600dad44b6f8e9370da9cad39fcf580d916e75ad9
[TRC] CORE: Checking match 9ad9a6e7feae2ffe8158ce9f182644c39d48a301cca9afc4855ce85b21c59575 (Maker) in status MakerSwapCast. Order: 9a76f9da8c42f60a0c46d39588a027b08c3833fa4f88f7df8b482b36e5dbb2f1, Refund coin: , Script: 6382012088a82016f2ac7f1b7e5e92e5da2f1136
62ebc7a2d490e7fee318340b876704f01f515fb17576a91435f5c17280338aaf0e8e2ada680f7f6b83365d9b6888ac
[INF] CORE: Contract for match 9ad9a6e7feae2ffe8158ce9f182644c39d48a301cca9afc4855ce85b21c59575 with swap coin 1773e333c069a48c920720e6d5caf4477a1241ab36a6d9271cdba970c1736b98:0 (btc) has an expiry time of 2020-09-03 16:55:12 +0000 UTC (1m43s), not yet expired.
...
[DBG] CORE: Refundable match 9ad9a6e7feae2ffe8158ce9f182644c39d48a301cca9afc4855ce85b21c59575 for order 9a76f9da8c42f60a0c46d39588a027b08c3833fa4f88f7df8b482b36e5dbb2f1 (Maker)
[INF] CORE: Failed match, no valid counterswap received from Taker, refunding btc contract 1773e333c069a48c920720e6d5caf4477a1241ab36a6d9271cdba970c1736b98:0
[WRN] CORE: notify: |WARNING| (order) Matches Refunded - Refunded 2.00000000 btc on order 9a76f9da - Order: 9a76f9da8c42f60a0c46d39588a027b08c3833fa4f88f7df8b482b36e5dbb2f1

client/core/core.go Outdated Show resolved Hide resolved
client/core/core.go Outdated Show resolved Hide resolved
@chappjc chappjc marked this pull request as ready for review September 3, 2020 15:01
client/core/core_test.go Outdated Show resolved Hide resolved
client/core/core_test.go Outdated Show resolved Hide resolved
client/core/core_test.go Outdated Show resolved Hide resolved
@chappjc chappjc merged commit aee9eac into decred:master Sep 3, 2020
@chappjc chappjc deleted the missing-matches-reversed branch September 3, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants