client: add support for dcr spv wallets #788
Merged
Commits on Nov 8, 2021
-
client/asset/dcr: add basic support for spv wallets
- Don't error for missing dcrdjsonrpcapi, instead set wallet.spvMode=true. - Replace getblockchaininfo with syncstatus to determine sync status.
-
-
-
multi: re-audit contracts after confirmation, before acting
There is a very slight possibility that contract outputs that pass audit while in mempool or in some cases before they are broadcasted (rawtx audit) may differ from the output later observed in a block for the same coin. This risk is higher for spv wallets that will mostly only perform audits on rawtxs before broadcasting the txs, without a guarantee that the tx is accepted to the mempool. A malicious actor could broadcast a different tx with same hash (theoretically possible) but with a different output at the expected vout index. There is risk of funds if clients only later check that the hash for the earlier-audited tx is found in a block and proceed to send their counter swap or expose their contract secret via a redemption. This commit aims to mitigate that risk by repeating contract audits after the initial tx hash is observed on the blockchain, ensuring that the tx now observed on the blockchain is as desired.
-
-
client/asset/dcr: remove added calls to getrawtransaction
The getrawtransaction rpc requires txindex to be enabled on full nodes but clients may run full nodes without enabling txindex as it is not a requirement. Use gettransaction where possible instead of getrawtransaction to avoid errors when clients use full nodes without txindex enabled.
-
-
-
fix dcr harness spv wallets startup issues fix SwapConfirmations error for wallet contracts fix output spent check bug and repaired log messages
-
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.