allow apps to listen on IPv6 addresses #899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on PR #882, so the commit of interest is bfb407e.
The issue is that
host + ":" port
is not always correct for IPv6 because the host needs brackets around it when joined with a port. This updates all the listen address parsing and construction code to work properly with IPv6.For dcrdex with
--rpclisten=[::1]:17232
:before
NewServer failed: address ::1:17232: too many colons in address
after
[INF] COMM: RPC server listening on [::1]:17232
A similar fix is applied to client.