Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcrlnd: add dcrlnd section #1055

Merged
merged 3 commits into from Jan 31, 2020
Merged

dcrlnd: add dcrlnd section #1055

merged 3 commits into from Jan 31, 2020

Conversation

fguisso
Copy link
Member

@fguisso fguisso commented Jan 14, 2020

I not the guy with good words, storytelling, can anyone help me please?

@fguisso fguisso marked this pull request as ready for review January 27, 2020 12:57
@@ -90,7 +90,6 @@ nav:
- 'dcrd and dcrwallet CLI Arguments': 'wallets/cli/dcrd-and-dcrwallet-cli-arguments.md'
- 'dcrctl RPC Commands': 'wallets/cli/dcrctl-rpc-commands.md'
- 'SPV': 'wallets/spv.md'
- 'Lightning Network (LN)': 'wallets/lightning.md'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we move a page, we need to add an nginx redirection here: https://github.com/decred/dcrdocs/blob/master/conf/nginx.conf

rewrite ^/wallets/lightning/?$               $scheme://$http_host/lightning-network/overview permanent;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, I removed this section, why I need to redirect this link?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somebody may have bookmarked the old URL, or there may be another site which is linking to this URL. We don't want to break their link, so we install a redirection to the new location

mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
docs/lightning-network/dcrlncli/addholdinvoice.md Outdated Show resolved Hide resolved
docs/lightning-network/dcrlncli/addholdinvoice.md Outdated Show resolved Hide resolved
docs/lightning-network/dcrlncli/unlock.md Outdated Show resolved Hide resolved
docs/lightning-network/dcrlncli/updatechanpolicy.md Outdated Show resolved Hide resolved
docs/lightning-network/dcrlncli/verifychanbackup.md Outdated Show resolved Hide resolved
docs/lightning-network/dcrlncli/verifychanbackup.md Outdated Show resolved Hide resolved
docs/lightning-network/overview.md Outdated Show resolved Hide resolved
@jholdstock jholdstock merged commit 64f19a3 into decred:master Jan 31, 2020
@xaur
Copy link

xaur commented Feb 5, 2020

I'm not seeing a bunch of nested pages added by this PR: https://docs.decred.org/wallets/lightning/ - the section is not expandable on the left nav tree. Am I missing something?

@fguisso
Copy link
Member Author

fguisso commented Feb 6, 2020

@xaur are you running local project? If not, the main website probably is waiting to the #1055 PR approving. Then new url will be https://docs.decred.org/lightning-network

@jholdstock
Copy link
Member

PR is merged but the new code has not yet been deployed to production. Awaiting dhill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants