Skip to content

Commit

Permalink
pool: resolve review issues (1 of x).
Browse files Browse the repository at this point in the history
  • Loading branch information
dnldd committed Oct 9, 2020
1 parent b909566 commit 7f154c4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ Dust payments render payout transactions non-standard causing it to fail, also
making participating accounts forfeit dust payments serves as a good deterrent
to accounts that contribute intermittent, sporadic work. Participating accounts
become compelled to commit and contribute enough resources to the pool worth
more than dust outputs to quarantee recieving dividends whenever the pool
more than dust outputs to guarantee receiving dividends whenever the pool
mines a block.

## Testing
Expand Down
9 changes: 4 additions & 5 deletions pool/paymentmgr.go
Original file line number Diff line number Diff line change
Expand Up @@ -552,11 +552,10 @@ func (pm *PaymentMgr) calculatePayments(ratios map[string]*big.Rat, source *Paym
txrules.DefaultRelayFeePerKb) {
// Since dust payments will cause the payout transaction to error
// and are also most likely to be generated by participating
// accounts contributing sporadic work to pool, for these reasons
// dust payments will be forfeited by the accounts that generated
// them and be added to the pool fee payout. This intended
// to serve as a deterrent for contributinf sporadic work
// to the pool.
// accounts contributing sporadic work to pool they will be
// forfeited by their corresponding accounts and be added to
// the pool fee payout. This is intended to serve as a deterrent
// for contributing intermittent, sporadic work to the pool.
dustAmts = append(dustAmts, amt)
} else {
payments = append(payments, NewPayment(account, source, amt, height,
Expand Down
2 changes: 1 addition & 1 deletion pool/paymentmgr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1733,7 +1733,7 @@ func testPaymentMgr(t *testing.T, db *bolt.DB) {
t.Fatalf("unable to generate payments: %v", err)
}

// Ensure the payments created are for accounts x, y and a fee
// Ensure the payments created are for account y and a fee
// payment entry.
pmts, err = mgr.pendingPayments()
if err != nil {
Expand Down

0 comments on commit 7f154c4

Please sign in to comment.