Postgres implementation. #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a full postgres database implementation for dcrpool. - New config items to enable postgres and set database connection details. - Updated documentation to explain postgres usage. - Database backup features are disabled when using postgres. - All database tests are now run against both bolt and postgres database.
dnldd
reviewed
Nov 3, 2020
jholdstock
force-pushed
the
postgres-impl3
branch
from
dbf03a1
to
9cf90cd
Compare
dnldd
requested changes
Nov 3, 2020
|
Caught the race below in testing, but I believe I already handled it in the upcoming single miner endpoint pr. ==================
WARNING: DATA RACE
Read at 0x00c00034d800 by goroutine 57:
internal/race.Read()
/usr/local/go/src/internal/race/race.go:37 +0x206
sync.(*WaitGroup).Add()
/usr/local/go/src/sync/waitgroup.go:71 +0x219
github.com/decred/dcrpool/pool.(*Endpoint).connect()
/home/dnldd/Work/dcrpool/pool/endpoint.go:187 +0x11c9
Previous write at 0x00c00034d800 by goroutine 55:
internal/race.Write()
/usr/local/go/src/internal/race/race.go:41 +0x125
sync.(*WaitGroup).Wait()
/usr/local/go/src/sync/waitgroup.go:128 +0x126
github.com/decred/dcrpool/pool.(*Endpoint).run()
/home/dnldd/Work/dcrpool/pool/endpoint.go:229 +0xec
Goroutine 57 (running) created at:
github.com/decred/dcrpool/pool.(*Endpoint).run()
/home/dnldd/Work/dcrpool/pool/endpoint.go:227 +0xa8
Goroutine 55 (finished) created at:
github.com/decred/dcrpool/pool.testEndpoint()
/home/dnldd/Work/dcrpool/pool/endpoint_test.go:86 +0xa57
testing.tRunner()
/usr/local/go/src/testing/testing.go:1108 +0x202
================== |
|
Yeah I have seen that race occassionally as well. Not related to this PR afaict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a full postgres database implementation for dcrpool.
Closes #257