multi: various improvements #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
requested changes
Dec 31, 2020
| return nil, nil, err | ||
| } | ||
|
|
||
| // Create the data directory. | ||
| err = os.MkdirAll(cfg.DataDir, 0700) | ||
| if err != nil { | ||
| str := "%s: failed to create data directory: %v" | ||
| err := fmt.Errorf(str, funcName, err) | ||
| str := "%s: unable to create data directory (%s): %v" |
There was a problem hiding this comment.
funcName is used in a handful of places, but not all. Any reason? I guess we could remove it completely
There was a problem hiding this comment.
I think it makes sense to keep it for config related errors resulting from creating directories, generating certificates etc which are not directly related to the config process.Errors related to config parsing and parameter constraints can do without the func name label since those indicate an app-wide config issue that's why funcName is used only in some places.
dnldd
force-pushed
the
various_fixes
branch
2 times, most recently
from
e196c92
to
010dd5f
Compare
This adds additional checks for the --pool config to ensure the supplied value is a valid address and the miner is not started without one.
This adds additional checks for postgres config options and improves config error outputs.
This removes the letsencrypt http redirect because clients should be expecting an https service and if there is a need to for a redirect the pool operator's web server should be capable.
This fixes a bug where solo pool gui where not updating mined work properly because the cache was not being properly updated on block connections. This fix also moe efficiently confirms work.
This refactors the prrocess of establishing a node connection and a wallet connection to avoid the use of setters for the connections.
This adds example outputs for pool startups for solo pool mode and public pool mode.
jholdstock
reviewed
Jan 7, 2021
|
All good after fixing that typo |
|
Had to push another commit. |
jholdstock
requested changes
Jan 15, 2021
This updates the cpu miner stratum handshake to only send an authorization request after the subscription request has been processed.
jholdstock
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves config options handling, error outputs and letsencrypt http redirects.