Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reverse proxy deployments #301

Merged
merged 4 commits into from
Feb 10, 2021
Merged

Conversation

jholdstock
Copy link
Member

This PR is to enable dcrpool deployments behind a dedicated webserver acting as a reverse proxy.

Changes:

  • Listen for GUI connections on plain HTTP (previously hard-coded to HTTPS)
  • Make listening IPs for GUI and miner connections configurable (previously hard-coded to 0.0.0.0)

Marking as a draft for now - I will mark for review once I have completed a test deployment behind an nginx instance.

@jholdstock jholdstock marked this pull request as ready for review January 27, 2021 15:54
@jholdstock
Copy link
Member Author

Deployed behind nginx at https://pool.jholdstock.uk

Copy link
Member

@dnldd dnldd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but missing a couple configuration checks.

config.go Show resolved Hide resolved
config.go Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
gui/index.go Outdated Show resolved Hide resolved
@jholdstock jholdstock merged commit 4ba2828 into decred:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants