Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: update a homedir config flag. #312

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Mar 12, 2021

This updates the --homedir flag to --appdata to be consistent with dcrd and dcrwallet.

This is a breaking change. Normally deprecation would be preferred but since the upcoming release already has breaking changes
and it'd not be great managing two homedir config vars with different values.

Resolves #307

Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes fine so far, but

  • README needs updating in two places.
  • We might as well update the same thing in cmd/miner/config.go as well.

This updates the --homedir flag to --appdata to be consistent with dcrd and dcrwallet. This is a breaking change.
@dnldd dnldd merged commit 103a84d into decred:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--homedir config is not consistent with dcrd
2 participants