Remove unnecessary Fetch funcs for txBroadcaster and txCreator #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jholdstock
commented
Oct 24, 2023
jholdstock
commented
- Wrapping the TxCreator and TxBroadcaster in Fetch funcs adds lots of boilerplate code but offers no tangible benefit in return.
- The txCreator and txBroadcaster interfaces are not used anywhere other than the pool package so they don't need to be exported.
Wrapping the TxCreator and TxBroadcaster in Fetch funcs adds lots of boilerplate code but offers no tangible benefit in return.
The txCreator and txBroadcaster interfaces are not used anywhere other than the pool package.
davecgh
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.