gui: Display miner ip:port on account page. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The miner ip:port are already present in the connected client info so they can be displayed on the account page with only a minor change. Previously only the name of the miner software and the hashrate were displayed which made it impossible to distinguish which client was which. Having the ip:port of the client isn't much better, but it's definitely better than nothing.
davecgh
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The miner ip:port are already present in the connected client info so they can be displayed on the account page with only a minor change.
Previously only the name of the miner software and the hashrate were displayed which made it impossible to distinguish which client was which. Having the ip:port of the client isn't much better, but it's definitely better than nothing.