backend: allow using offline node #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that created transactions with tx version 0 if the metadata for tx version was unspecified. This could prevent transactions generated by the Construction API from being mined and relayed. We fix this by ensuring transactions generated by RosettaOpsToTx are initialized by the standard wire.NewMsgTx() function. Additionally, we switch some errors to variables for better identification and add tests to assert edge cases of the RosettaOpsToTx function.
This modifies the Server service to allow it connecting to a backing dcrd node that does not have any blockchain data. Such nodes are usually offline nodes, that are not connected to the larger network and are used only for the offline Construction API operations. This is implemented by waiting for peers for up to 10 seconds after the server is initialized. If no peers are found, initialization proceeds potentially skipping any blockchain sync or account preprocessing.
This adds tests for the Data and Construction APIs using dcrd's rpctest framework. This offers greater assurance that the overall integration between dcrros and dcrd nodes are working as expected. The Github Actions CI workflow has been updated to checkout and install the latest stable dcrd version in order for the tests to run in that CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to run an offline dcrros node. This is needed in order to fully fulfill the specs for the Construction API, where certain operations are only performed in offline instances (that is, instances not connected to the larger underlying blockchain network).
A set of tests based on dcrd's rpctest package are added to ensure conformance to the requirements for offline nodes when used in a Construction API workflow as proposed by the Rosetta specs.