-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to handle getticketsvotebits errors better #15
Comments
This isn't only for missed and revoked tickets right? Or is this a separate issue? I assume this is where the ticket list comes from? Could we union the responses from the different wallets since mempool could literally be any subset of the overall mempool? (Seems like there is still always a chance that some tickets may not be in the list when they are still in the mempool). Or am I way off? |
I was just listing some examples of de-synchronization from past issues and the goal would be to have the code work in a way where the inconsistency isn't a problem. Can run ticketsforaddress and getticketsvotebits against each server individually. Or just have getticketsvotebits ignore passing of an invalid ticket and work with a single response, they will eventually be consistent but then users may complain about missing tickets. |
I won't be offended if PR #32 goes to the scrap heap. There's no extended bits handling, and it's complex. |
The situation was vastly improved by #60 so I don't see a reason to keep this open. |
votebits errors out when ticket doesn't exist due to mempool differences or when a missed/revoked ticket is present or not.
The text was updated successfully, but these errors were encountered: