Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to the golangci-lint linter #44

Merged
merged 1 commit into from Jan 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
Expand Up @@ -3,8 +3,7 @@ go:
- 1.11.x
sudo: false
install:
- go get -v github.com/alecthomas/gometalinter
- gometalinter --install
- go get -v github.com/golangci/golangci-lint/cmd/golangci-lint
script:
- export GO111MODULE=on
- (cd cmd/dcrtime && go build)
Expand Down
17 changes: 4 additions & 13 deletions goclean.sh
Expand Up @@ -13,22 +13,13 @@ set -ex
# run tests
env GORACE="halt_on_error=1" go test -race ./...

# Make sure gometalinter is installed and $GOPATH/bin is in your path.
# $ go get -v github.com/alecthomas/gometalinter"
# $ gometalinter --install"
if [ ! -x "$(type -p gometalinter)" ]; then
exit 1
fi
# golangci-lint (github.com/golangci/golangci-lint) is used to run each each
# static checker.

# check linters
# linters do not work with modules yet
go mod vendor
unset GO111MODULE

gometalinter --vendor --disable-all --deadline=10m \
golangci-lint run --disable-all --deadline=10m \
--enable=gofmt \
--enable=vet \
--enable=gosimple \
--enable=unconvert \
--enable=ineffassign \
./...
--enable=ineffassign