Avoid stdin passphrase prompt with --noinitialload.

Fixes #188.

dcrwallet.go

@@ -101,8 +101,7 @@ func walletMain() error {
 		TicketBuyFreq:      cfg.TicketBuyFreq,
 	}
 	loader := wallet.NewLoader(activeNet.Params, dbDir, stakeOptions,
-		cfg.AutomaticRepair, cfg.UnsafeMainNet, cfg.PromptPass,
-		cfg.AddrIdxScanLen)
+		cfg.AutomaticRepair, cfg.UnsafeMainNet, cfg.AddrIdxScanLen)
 
 	// Create and start HTTP server to serve wallet client connections.
 	// This will be updated with the wallet and chain server RPC client
@@ -120,7 +119,18 @@ func walletMain() error {
 	}
 
 	loader.RunAfterLoad(func(w *wallet.Wallet) {
-		startPromptPass(w)
+		// TODO(jrick): I think that this prompt should be removed
+		// entirely instead of enabling it when --noinitialload is
+		// unset.  It can be replaced with an RPC request (either
+		// providing the private passphrase as a parameter, or require
+		// unlocking the wallet first) to trigger a full accounts
+		// rescan.
+		//
+		// Until then, since --noinitialload users are expecting to use
+		// the wallet only over RPC, disable this feature for them.
+		if !cfg.NoInitialLoad {
+			startPromptPass(w)
+		}
 		startWalletRPCServices(w, rpcs, legacyRPCServer)
 	})
 

wallet/loader.go

@@ -52,7 +52,6 @@ type Loader struct {
 	stakeOptions   *StakeOptions
 	autoRepair     bool
 	unsafeMainNet  bool
-	promptPass     bool
 	addrIdxScanLen int
 }
 
@@ -74,14 +73,13 @@ type StakeOptions struct {
 // NewLoader constructs a Loader.
 func NewLoader(chainParams *chaincfg.Params, dbDirPath string,
 	stakeOptions *StakeOptions, autoRepair bool, unsafeMainNet bool,
-	promptPass bool, addrIdxScanLen int) *Loader {
+	addrIdxScanLen int) *Loader {
 	return &Loader{
 		chainParams:    chainParams,
 		dbDirPath:      dbDirPath,
 		stakeOptions:   stakeOptions,
 		autoRepair:     autoRepair,
 		unsafeMainNet:  unsafeMainNet,
-		promptPass:     promptPass,
 		addrIdxScanLen: addrIdxScanLen,
 	}
 }

walletsetup.go

@@ -122,8 +122,7 @@ func createWallet(cfg *config) error {
 		TicketMaxPrice:     cfg.TicketMaxPrice,
 	}
 	loader := wallet.NewLoader(activeNet.Params, dbDir, stakeOptions,
-		cfg.AutomaticRepair, cfg.UnsafeMainNet, cfg.PromptPass,
-		cfg.AddrIdxScanLen)
+		cfg.AutomaticRepair, cfg.UnsafeMainNet, cfg.AddrIdxScanLen)
 
 	// When there is a legacy keystore, open it now to ensure any errors
 	// don't end up exiting the process after the user has spent time