Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC ValidateAddress returning pkh address instead of pk address #1254

Closed
matheusd opened this issue Aug 16, 2018 · 1 comment · Fixed by #1255
Closed

gRPC ValidateAddress returning pkh address instead of pk address #1254

matheusd opened this issue Aug 16, 2018 · 1 comment · Fixed by #1255

Comments

@matheusd
Copy link
Member

matheusd commented Aug 16, 2018

The pubKeyAddress member of the response is returning back the p2pkh address instead of the pubkey address associated with the address passed in the request.

I believe this:
https://github.com/decred/dcrwallet/blob/master/rpc/rpcserver/server.go#L1699

needs to use String() instead of EncodeAddress() so that it is compatible to the legacy rpc validateAddress endpoint.

https://github.com/decred/dcrwallet/blob/master/rpc/legacyrpc/methods.go#L3363

@jrick
Copy link
Member

jrick commented Aug 16, 2018

Definitely agree. We can fix this and do a patch bump for the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants