[grpc] return pk instead of pkh in validateAddress #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Aug 16, 2018
|
Do you need this backported to the release-v1.3 branch? |
|
Not personally. I came up to this while working on the trezor integration, so this won't be needed before the next release. |
githubsands
pushed a commit
to githubsands/dcrwallet
that referenced
this pull request
Aug 19, 2018
githubsands
pushed a commit
to githubsands/dcrwallet
that referenced
this pull request
Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1254
The grpc endpoint ValidateAddress was previously returning the original public key hash address of the requested address instead of the correct public key address. This fixes the problem and bumps the patch level of the api.