Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out address pools #411

Closed
jrick opened this issue Nov 30, 2016 · 0 comments
Closed

Rip out address pools #411

jrick opened this issue Nov 30, 2016 · 0 comments
Assignees
Milestone

Comments

@jrick
Copy link
Member

jrick commented Nov 30, 2016

These are a hack on top of a waddrmgr that was unable to derive and record addresses beyond the next to use address. They should not belong in the code any longer. In addition, they seem to be non-atomic and rely on clean database shutdown in order to update waddrmr with their latest state.

I don't expect any performance penalty for removing them either, since database update transactions are already always required to return a new address from them, in the case that more addresses must be derived.

Removing address pools should also bring the code closer to btcwallet making any future syncs slightly less awful.

@jrick jrick added this to the future milestone Nov 30, 2016
@jrick jrick modified the milestones: 0.8.0, future Dec 26, 2016
@jrick jrick modified the milestones: future, 0.8.0 Feb 1, 2017
@jrick jrick modified the milestones: 0.9.0, future Feb 23, 2017
@jrick jrick self-assigned this Feb 23, 2017
@jrick jrick closed this as completed in #636 Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant