Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for a series of two commits and should not be squashed. The first commit adds a test artifact using the old version of the udb package. Code to generate the test database was included in this commit as well, and can be run again if necessary by checking out this commit. The second commit implements the upgrade and updates the wallet for the new APIs. The old test db code generation will not run on anything but the first commit and should not be updated.
The new implementation is much simpler and safer, and provides more
useful features as well. Addresses are now derived based on the last
used address, rather than incrementing and keeping track of a child
index to next use. Address activity lookahead has been implemented so
that other wallets sharing the same seed will stay in sync so long as
all wallets respect the BIP0044 gap limit.
Fix account generation after 100 accounts have been derived so that
derivation is allowed when any of the previous 100 accounts have
public activity rather than just the previous account.
This change involves a database upgrade to version 4. This version
removes the next-to-use account branch child indexes, replacing them
with the last used child index.
Fixes #112.
Fixes #411.
Fixes #580.
Fixes #603.
Fixes #635.