Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account gap check works incorrectly after 100 accounts #635

Closed
jrick opened this issue Mar 31, 2017 · 0 comments
Closed

Account gap check works incorrectly after 100 accounts #635

jrick opened this issue Mar 31, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@jrick
Copy link
Member

jrick commented Mar 31, 2017

The comment on Wallet.NextAccount currently says:

// NextAccount creates the next account and returns its account number.  The
// name must be unique to the account.  In order to support automatic seed
// restoring, new accounts may not be created when all of the previous 100
// accounts have no transaction history (this is a deviation from the BIP0044
// spec, which allows no unused account gaps).

However it does not behave this way. Instead, if the account number is over 100, it only checks if the previous account has any history, instead of checking the last 100.

The account has history check is also broken. It is intended to check whether there has been any transaction activity for the account, but instead it only checks if addresses have been generated for the account.

@jrick jrick added the bug label Mar 31, 2017
@jrick jrick added this to the v1.0.0 milestone Mar 31, 2017
@jrick jrick self-assigned this Mar 31, 2017
@jrick jrick closed this as completed in #636 Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant