Fix a bug relating to relevantTx handling and uncaught error #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err == nil { | ||
| sa, ok := scrAddr.(waddrmgr.ManagedScriptAddress) | ||
| if !ok { | ||
| log.Warnf("address %v is not a script"+ |
There was a problem hiding this comment.
If this actually happens, it will panic below where it dereferences sa (both in the log, and when it fetches the retrievedScript in the non-error path).
cjepson
force-pushed
the
cj_100316chainntfns
branch
from
c388c15
to
d7b5398
Compare
A call to UnspentOutpoints did not have error handling, which was added. A restrictive switch statement would cause all outputs that were not either pay-to-pubkey hash or pay-to-script-hash multisig to be stored. This was reverted to the same behavior as btcwallet where all outputs are stored if the address is found in the address manager. Code handling multisignature redeemScript lookup in outputs was also corrected.
cjepson
force-pushed
the
cj_100316chainntfns
branch
from
d7b5398
to
423bd7f
Compare
|
tACK |
beansgum
pushed a commit
to beansgum/dcrwallet
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to UnspentOutpoints did not have error handling, which was
added.
A restrictive switch statement would cause all outputs that were not
either pay-to-pubkey hash or pay-to-script-hash multisig to be stored.
This was reverted to the same behavior as btcwallet where all outputs
are stored if the address is found in the address manager. Code
handling multisignature redeemScript lookup in outputs was also
corrected.