Fix all rpclisten references in documentation #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Thanks for the PR. Looks correct to me. OK |
|
utACK looks good |
|
looks good, but can you rebase to current master? then it can go right in |
|
It looks like this commit can merge cleanly? |
|
It is much preferred to keep a clean history that is not cluttered up with useless merge commits. There are definitely times where merge commits make sense such as when syncing upstream, but for normal additions like this, they really don't make any sense. |
jyap808
changed the title
|
OK done. Hope I did it right. I also modified the commit message slightly. Changed "rpcport" to "rpclisten". Cheers. |
|
great looks good, thanks for doing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #99