Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default TLS elliptic curve from P-521 to P-256. #1468

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Switch default TLS elliptic curve from P-521 to P-256. #1468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ func loadConfig(ctx context.Context) (*config, []string, error) {
PromptPublicPass: defaultPromptPublicPass,
RPCKey: cfgutil.NewExplicitString(defaultRPCKeyFile),
RPCCert: cfgutil.NewExplicitString(defaultRPCCertFile),
TLSCurve: cfgutil.NewCurveFlag(cfgutil.CurveP521),
TLSCurve: cfgutil.NewCurveFlag(cfgutil.CurveP256),
LegacyRPCMaxClients: defaultRPCMaxClients,
LegacyRPCMaxWebsockets: defaultRPCMaxWebsockets,
EnableTicketBuyer: defaultEnableTicketBuyer,
Expand Down
2 changes: 1 addition & 1 deletion rpctest/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (n *node) Cleanup() error {
func genCertPair(certFile, keyFile, certFileWallet, keyFileWallet string) error {
org := "rpctest autogenerated cert"
validUntil := time.Now().Add(10 * 365 * 24 * time.Hour)
cert, key, err := certgen.NewTLSCertPair(elliptic.P521(), org, validUntil,
cert, key, err := certgen.NewTLSCertPair(elliptic.P256(), org, validUntil,
nil)
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion sample-dcrwallet.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
; rpckey=~/.dcrwallet/rpc.key

; Curve to use when autogenerating TLS keypairs
; tlscurve=P-521
; tlscurve=P-256

; Enable one time TLS keys. This option results in the process generating
; a new certificate pair each startup, writing only the certificate file
Expand Down