Use decred.org/dcrwallet as main module name #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Sep 13, 2019
davecgh
approved these changes
Sep 13, 2019
This modifies packages of the main module to begin with the decred.org/dcrwallet prefix. This is a long overdue change since the conversion to modules technically should have caused a /v2 module to be created, but due to other project decisions, it was not possible to bump dcrwallet's major version to 2. Renaming the module has the same desired effect, however. Because this change creates a new (and unrelated) module to the previous github.com/decred/dcrwallet module, this opportunity is used to move all packages from the main module which are not versioned or intended for external consumption under the internal directory. Because this module shares the same git repo and history as github.com/decred/dcrwallet, versioning will begin at 1.5.0. To simplify this conversion process, the github.com/decred/dcrwallet/internal/zero module has been discarded. It is easier to copy the zero functions where needed rather than maintaining an internal package across many modules with different prefixes. This change will eventually allow the latest release of dcrwallet to be installed with go get with the simple command: $ go get decred.org/dcrwallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies packages of the main module to begin with the
decred.org/dcrwallet prefix. This is a long overdue change since the
conversion to modules technically should have caused a /v2 module to
be created, but due to other project decisions, it was not possible to
bump dcrwallet's major version to 2. Renaming the module has the same
desired effect, however.
Because this change creates a new (and unrelated) module to the
previous github.com/decred/dcrwallet module, this opportunity is used
to move all packages from the main module which are not versioned or
intended for external consumption under the internal directory.
Because this module shares the same git repo and history as
github.com/decred/dcrwallet, versioning will begin at 1.5.0.
To simplify this conversion process, the
github.com/decred/dcrwallet/internal/zero module has been discarded.
It is easier to copy the zero functions where needed rather than
maintaining an internal package across many modules with different
prefixes.
This change will eventually allow the latest release of dcrwallet to
be installed with go get with the simple command:
$ go get decred.org/dcrwallet