Allow accounts to be individually encrypted and unlocked #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vctt94
reviewed
Aug 29, 2020
There was a problem hiding this comment.
I set the account passphrase and looks like it worked, but if I unlock the account and try sending from it, I get a wallet passphrase error:
vctt@vctt:~/projects/decred/dcrctl$ go build && ./dcrctl --testnet --wallet unlockaccount default 123
vctt@vctt:~/projects/decred/dcrctl$ go build && ./dcrctl --testnet --wallet sendfrom default TsfDLrRkk9ciUuwfp2b8PawwnukYD7yAjGd 1
-13: enter the wallet passphrase with walletpassphrase first
jrick
force-pushed
the
accountencryption
branch
from
ff1b9fe
to
52516aa
Compare
vctt94
approved these changes
Sep 9, 2020
|
That's a good suggestion. Unfortunately the most sensible RPC to add this to (listaccounts) would need a breaking change to the response format to support something like this. |
|
the account properties (returned by w.Accounts) now includes if the account has a per-account passphrase set on it, and whether it is locked or unlocked, which should be useful for the grpc server since it does return this data directly (unlike jsonrpc). |
jrick
force-pushed
the
accountencryption
branch
2 times, most recently
from
c203d20
to
9763fe4
Compare
This was referenced Sep 9, 2020
Closed
jrick
force-pushed
the
accountencryption
branch
3 times, most recently
from
3007699
to
82e422e
Compare
This commit introduces three new RPCs (setaccountpassphrase, unlockaccount, and lockaccount) which can be used to set a unique passphrase for and allow individual locking of particular accounts, separate from the global keys used to encrypt all other accounts. Argon2id is used as the KDF for individually encrypted accounts, and XChaCha20-Poly1305 is used for authenticated encryption of account xprivs. The new KDF parameters use the same memory difficulty (256M) as the scrypt parameters used for all other accounts.
jrick
force-pushed
the
accountencryption
branch
from
0254399
to
88b3d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces three new RPCs (setaccountpassphrase,
unlockaccount, and lockaccount) which can be used to set a unique
passphrase for and allow individual locking of particular accounts,
separate from the global keys used to encrypt all other accounts.
Argon2id is used as the KDF for individually encrypted accounts, and
XChaCha20-Poly1305 is used for authenticated encryption of account
xprivs. The new KDF parameters use the same memory difficulty (256M)
as the scrypt parameters used for all other accounts.