Vsp changes #1840
Merged
Vsp changes #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2020
dajohi
reviewed
Sep 11, 2020
internal/rpc/rpcserver/server.go
Outdated
| @@ -2440,6 +2440,8 @@ func (t *ticketbuyerV2Server) RunTicketBuyer(req *pb.RunTicketBuyerRequest, svr | |||
| // new vspd request | |||
| var vspHost string | |||
| var vspPubKey string | |||
| var vspServer *vsp.VSP | |||
| isVspdReq := false | |||
There was a problem hiding this comment.
remove isVspdReq, and just use if vspServer != nil
vctt94
force-pushed
the
vsp-changes
branch
7 times, most recently
from
1eba0c9
to
2fe6894
Compare
dajohi
reviewed
Sep 14, 2020
vsp/vsp.go
Outdated
| @@ -126,7 +126,7 @@ func New(hostname, pubKeyStr string, purchaseAccount, changeAccount uint32, dial | |||
| log.Infof("VSP has successfully confirmed the fee tx for %v", txHash) | |||
| case "error": | |||
| log.Warnf("VSP failed to broadcast feetx for %v -- restarting process", txHash) | |||
| v.Queue(ctx, *txHash, nil) | |||
| v.Queue(ctx, *txHash, feeTx) | |||
There was a problem hiding this comment.
I think this is wrong; this will retry with the same feeTx. The nil retries by generating a new feetx.
vctt94
force-pushed
the
vsp-changes
branch
3 times, most recently
from
0fb7201
to
5c7f83d
Compare
dajohi
approved these changes
Sep 23, 2020
jrick
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR I am spliting changes which are related to vsp from #1819 to this PR.
I will rebase #1819 to keep only changes related to db.