Add fee processment status and process it later #1866

vctt94 · 2020-10-07T13:08:03Z

~~This PR aims to store the fee tx processment status. This is needed because we need to know when it fails to process, so we can retry it, in the future.~~

Right now if a vsp fail to process a vsp ticket, dcrawllet will continue the execution and will never process it again.

This PR creates a new field on the VSPTicket struct: FeeTxStatus, and store when the vsp ticket fee payment process has failed.

I am adding checks for when dcrwallet has it initial load and add two new grpc requests so I can deal with it on decrediton:
SyncVSPFailedTickets and FailedVSPTicketsProcess.

FailedVSPTicketsProcess gets all vsp tickets which errored. It has an empty request, which can be used for knowing if decrediton has unregistered vsp tickets.

SyncVSPFailedTickets Will sync them and because of that it needs a vsphost and vsppubkey into the request.

jrick · 2020-10-16T17:49:53Z

dcrwallet.go

@@ -242,6 +243,17 @@ func run(ctx context.Context) error {
 			passphrase = startPromptPass(ctx, w)
 		}

+		// Process VSP tickets that failed to be processed.


I feel iffy about putting all of this into the application startup code. At least for decrediton's purposes, it would be fine to only report status and react to it over RPC.

jrick · 2020-10-19T15:38:42Z

rpc/api.proto

+message SyncVSPTicketsResponse {}
+
+message GetVSPTicketsByFeeStatusRequest {
+	int32 fee_status = 1;


protobuf has enums, use that for these states, instead of plain integers.

jrick · 2020-10-19T15:40:30Z

wallet/udb/vsp.go

+const (
+	// VSP_FEE_PROCESS_STARTED represents the state which process has being
+	// called but fee still not paid.
+	VSP_FEE_PROCESS_STARTED   = 0


SCREAMING_CAPS is not go style, UseNamesLikeThis.

These constants should also use a defined type, and the constants should be declared using iota.

wallet/udb/vsp.go

jrick · 2020-10-19T15:44:04Z

wallet/wallet.go

+// informed fee status.
+func (w *Wallet) GetVSPTicketsByFeeStatus(ctx context.Context, feeStatus int) ([]chainhash.Hash, error) {
+	const op errors.Op = "wallet.GetVSPTicketsByFeeStatus"
+	tickets := make(map[chainhash.Hash]*udb.VSPTicket)


don't make if you are going to overwrite this anyways. just declare the variable.

jrick · 2020-10-19T15:44:22Z

wallet/wallet.go

+// UpdateVSPTicket updates the vsp ticket for the informed tickethash.
+func (w *Wallet) UpdateVSPTicket(ctx context.Context, ticketHash *chainhash.Hash, vspTicket udb.VSPTicket) error {
+	var err error
+	w.lockedOutpointMu.Lock()


this mutex acquire is not needed here.

jrick · 2020-10-19T15:44:28Z

wallet/wallet.go

+// SetPublished sets the informed hash as true or false.
+func (w *Wallet) SetPublished(ctx context.Context, hash *chainhash.Hash, published bool) error {
+	var err error
+	w.lockedOutpointMu.Lock()


jrick · 2020-10-19T15:44:40Z

wallet/wallet.go

+
+func (w *Wallet) UpdateVspTicketFeeToPaid(ctx context.Context, ticketHash *chainhash.Hash, feeHash *chainhash.Hash) error {
+	var err error
+	w.lockedOutpointMu.Lock()


wallet/wallet.go

…s vsp fee value

jrick · 2020-10-19T18:18:09Z

internal/rpc/rpcserver/server.go

+			return nil, err
+		}
+	}
+	return nil, nil


this should return &pb.SyncVSPTicketsResponse{}, not nil

jrick · 2020-10-19T18:21:33Z

wallet/udb/vsp.go

+	VSPFeeProccesStarted = 0
+	// VSPFeeProcessPaid represents the state where the process has being
+	// paid, but not published.
+	VSPFeeProcessPaid = 1
+	// TODO change fee status to published, once fee tx is published.
+	VSPFeeProcessPublished = 2
+	VSPFeeProcessErrored   = 3


Use iota and a type

type VSPFeeStatus int const ( // VSPFeeProccesStarted represents the state which process has being // called but fee still not paid. VSPFeeProccesStarted VSPFeeStatus = iota // VSPFeeProcessPaid represents the state where the process has being // paid, but not published. VSPFeeProcessPaid // TODO change fee status to published, once fee tx is published. VSPFeeProcessPublished VSPFeeProcessErrored

also please take care of that TODO, remove it if that's fixed.

jrick · 2020-10-19T18:29:42Z

wallet/udb/vsp.go

+const (
+	// VSPFeeProccesStarted represents the state which process has being
+	// called but fee still not paid.
+	VSPFeeProccesStarted = 0


This is a typo, should be VSPFeeProcessStarted

rpc/api.proto

jrick · 2020-10-19T18:58:40Z

rpc/api.proto

+		VSP_FEE_PROCESS_PAID = 1;
+		VSP_FEE_PROCESS_ERRORED = 2;
+	}
+	FeeStatus feeStatus = 3;


fee_status

jrick · 2020-10-19T18:59:42Z

wallet/createtx.go

+	if err != nil {
+		return nil, errors.E(op, err)
+	}


i might have introduced this when i rebased, but it should be removed.

vctt94 force-pushed the vsp-fee-sttus branch 2 times, most recently from 27ceeb6 to 6509db9 Compare October 9, 2020 20:43

vctt94 changed the title ~~[wip] udb/vsp: Add fee processment status~~ udb/vsp: Add fee processment status Oct 9, 2020

vctt94 changed the title ~~udb/vsp: Add fee processment status~~ Add fee processment status and process it later Oct 9, 2020

vctt94 force-pushed the vsp-fee-sttus branch 3 times, most recently from 69c44da to f3f1e2d Compare October 15, 2020 14:25

jrick reviewed Oct 16, 2020

View reviewed changes

vctt94 force-pushed the vsp-fee-sttus branch 5 times, most recently from 9c515d6 to 95fe39d Compare October 19, 2020 15:18

jrick requested changes Oct 19, 2020

View reviewed changes

jrick force-pushed the vsp-fee-sttus branch 2 times, most recently from 2ae6193 to ab3ac3f Compare October 19, 2020 18:01

vctt94 and others added 4 commits October 19, 2020 15:15

multi: Add vsp fee status, so we can list tickets on decrediton by it…

c53b07f

…s vsp fee value

add db upgrade, setting all current vspd recored tix in errored status

9802286

comments about the upgrade go on the version consts

7a9b010

review fixes

a21f70b

vctt94 force-pushed the vsp-fee-sttus branch from 79da45a to a21f70b Compare October 19, 2020 18:16

jrick reviewed Oct 19, 2020

View reviewed changes

vctt94 added 2 commits October 19, 2020 15:31

typo

7403005

remove unecessary state

89da5ef

jrick reviewed Oct 19, 2020

View reviewed changes

rpc/api.proto Show resolved Hide resolved

fix enum

e67ec7b

jrick reviewed Oct 19, 2020

View reviewed changes

rpc/api.proto Outdated

VSP_FEE_PROCESS_PAID = 1;

VSP_FEE_PROCESS_ERRORED = 2;

}

FeeStatus feeStatus = 3;

Copy link

Member

jrick Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fee_status

jrick reviewed Oct 19, 2020

View reviewed changes

vctt94 added 4 commits October 19, 2020 16:00

clean up

bbbe4ce

fix fee_status

a8100f8

define constant using iota

e0f3866

return proper value

22558b3

jrick approved these changes Oct 19, 2020

View reviewed changes

jrick merged commit fdc4bf4 into decred:master Oct 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fee processment status and process it later #1866

Add fee processment status and process it later #1866

vctt94 commented Oct 7, 2020 •

edited

Loading

jrick Oct 16, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020 •

edited

Loading

jrick Oct 19, 2020

jrick Oct 19, 2020

jrick Oct 19, 2020

Add fee processment status and process it later #1866

Add fee processment status and process it later #1866

Conversation

vctt94 commented Oct 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrick Oct 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vctt94 commented Oct 7, 2020 •

edited

Loading

jrick Oct 19, 2020 •

edited

Loading