Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve heuristic for creating additional split tx #2034

Merged
merged 1 commit into from
May 4, 2021

Conversation

jrick
Copy link
Member

@jrick jrick commented May 4, 2021

When the additional split transaction must be created, the total
balance from the account that had been reserved for all fee txs and
all ticket purchases can be summed together, to determine if it is
enough to create the additional split transaction. Previously, only
the partial balance of some of the selected inputs were being used,
and this had been triggering an unnecessary insufficient balance error
when attempting to create the additional split transaction would have
been a better idea.

When the additional split transaction must be created, the total
balance from the account that had been reserved for all fee txs and
all ticket purchases can be summed together, to determine if it is
enough to create the additional split transaction.  Previously, only
the partial balance of some of the selected inputs were being used,
and this had been triggering an unnecessary insufficient balance error
when attempting to create the additional split transaction would have
been a better idea.
@jrick jrick merged commit bf48275 into decred:master May 4, 2021
@jrick jrick deleted the insufficientbalance branch May 4, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants