Improve heuristic for creating additional split tx #2034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the additional split transaction must be created, the total
balance from the account that had been reserved for all fee txs and
all ticket purchases can be summed together, to determine if it is
enough to create the additional split transaction. Previously, only
the partial balance of some of the selected inputs were being used,
and this had been triggering an unnecessary insufficient balance error
when attempting to create the additional split transaction would have
been a better idea.