Don't attempt to vote/revoke without the private key #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error is commonly seen on ticketbuyer wallets which will attempt to revoke any missed tickets, even though an importing voting xpub account prevents access to the private keys to do so. This is not an error, and should be detected up front before ever constructing the unsigned vote/revocation. When the private key is recorded by the wallet, but the wallet or account is locked, the wallet will still error when failing to sign the revocation.
JoeGruffins
approved these changes
Jun 18, 2021
Comment on lines
+2328
to
+2331
| id, err := addressID(addr) | ||
| if err != nil { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
Better to return err here because we were expecting P2PK or P2PKH addr which should have an ID? ofc not sure tho.
There was a problem hiding this comment.
addressIDuses a check for Hash160er which also supports P2SH, Schnorr, etc. This will really only err for a completely unknown address type, in which case we don`t have the private key anyway, so this fulfills the API for this func.
matheusd
approved these changes
Jun 18, 2021
Comment on lines
+2328
to
+2331
| id, err := addressID(addr) | ||
| if err != nil { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
addressIDuses a check for Hash160er which also supports P2SH, Schnorr, etc. This will really only err for a completely unknown address type, in which case we don`t have the private key anyway, so this fulfills the API for this func.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is commonly seen on ticketbuyer wallets which will attempt
to revoke any missed tickets, even though an importing voting xpub
account prevents access to the private keys to do so. This is not an
error, and should be detected up front before ever constructing the
unsigned vote/revocation.
When the private key is recorded by the wallet, but the wallet or
account is locked, the wallet will still error when failing to sign
the revocation.