rpc: Add TSpendPolicies and SetTSpendPolicy requests #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ remove the updateVSPVoteChoices function call from TreasuryPolicies and SetTSpendPolicy and in SetVspdVoteChoices function update all treasuryPolicies and tspendPolicies and not just the ones that related to a particalar ticket
matheusd
approved these changes
Nov 14, 2022
jrick
reviewed
Nov 28, 2022
internal/rpc/rpcserver/server.go
Outdated
Comment on lines
3401
to
3402
| // If a VSP host is configured in the application settings, the voting | ||
| // preferences will also be set with the VSP. |
There was a problem hiding this comment.
This doesn't appear to be the case. Besides, we will want to use the VSP that is associated with each live ticket to be updated, and not the one in the current application settings.
There was a problem hiding this comment.
looks like this is being handled by another rpc call, so this comment can just be nuked and then this looks ok to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow decrediton to now get and update the pending tspend policies.
Notes:
SetTSpendPolicydoes not update VSPs about the vote choices, but decrediton takes care of it by callingSetVspdVoteChoices, just like when voting to the consensus changes. This applies toSetTreasuryPolicytoo. Closes [treasury spending] Changing Voting for preference to Yes give error decrediton#3763SetVspdVoteChoicesfunction updates alltreasuryPoliciesandtspendPoliciesnow and not just the ones that related to a particular ticket.