Respect proxy config for SPV and P2P seeder connections #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
approved these changes
Sep 7, 2022
dajohi
approved these changes
Sep 7, 2022
davecgh
reviewed
Sep 7, 2022
p2p/peering.go
Outdated
| @@ -181,7 +181,7 @@ func newNetAddress(addr net.Addr, services wire.ServiceFlag) (*wire.NetAddress, | |||
| return nil, fmt.Errorf("newNetAddress: unsupported address "+ | |||
| "type %T", addr) | |||
| } | |||
| if ip.IsLoopback() || ip.IsPrivate() { | |||
| if !ip.IsGlobalUnicast() { | |||
There was a problem hiding this comment.
I think you'd want to not bother sending private addresses back either which this doesn't do.
package main
import (
"fmt"
"net"
)
func main() {
ipv4Private1 := net.ParseIP("10.0.0.1")
ipv4Private2 := net.ParseIP("172.16.0.1")
ipv4Private3 := net.ParseIP("192.168.0.1")
ipv6Private1 := net.ParseIP("fc00::1")
p := func(ip net.IP) {
fmt.Printf("%v (IsGlobalUnicast: %v, IsPrivate: %v)\n", ip, ip.IsGlobalUnicast(), ip.IsPrivate())
}
p(ipv4Private1)
p(ipv4Private2)
p(ipv4Private3)
p(ipv6Private1)
}Output:
10.0.0.1 (IsGlobalUnicast: true, IsPrivate: true)
172.16.0.1 (IsGlobalUnicast: true, IsPrivate: true)
192.168.0.1 (IsGlobalUnicast: true, IsPrivate: true)
fc00::1 (IsGlobalUnicast: true, IsPrivate: true)
There was a problem hiding this comment.
Meh, you already updated it in the next commit.
davecgh
approved these changes
Sep 7, 2022
Remove the address of the local peer from the handshake. This is to prevent leaking internal network details and if a proxy is in use. Peers are also no longer informed of their external address if the address is loopback or a private or shared address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.