Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove btcd/wire dependency. #229

Merged
merged 1 commit into from May 4, 2016
Merged

Remove btcd/wire dependency. #229

merged 1 commit into from May 4, 2016

Conversation

jrick
Copy link
Member

@jrick jrick commented May 4, 2016

Fixes #228.

@davecgh
Copy link
Member

davecgh commented May 4, 2016

I like the concept. The only part I question is that I believe btcd/wire uses the fastsha256 package and I think that package is also used elsewhere within Decred, so I think this will end up resulting in having duplicate sha code. That said, I don't believe there is really any reason for Decred to continue using that package as the only reason it still exists is because the getwork RPC in btcd requires access to the midstate whereas I'm fairly certain Decred does not include it.

OK.

@jrick
Copy link
Member Author

jrick commented May 4, 2016

right, we don't need fastsha256 for decred anymore, anywhere.

@alexlyp
Copy link
Member

alexlyp commented May 4, 2016

OK

@jcvernaleo
Copy link
Member

I'm always happy for one less dependence. OK from me too (but if you want to wait until after the sync this one can sit until then). Doesn't matter to me.

@cjepson
Copy link
Contributor

cjepson commented May 4, 2016

OK

@alexlyp alexlyp merged commit c033392 into decred:master May 4, 2016
@jrick jrick deleted the nobtcddep branch May 4, 2016 19:31
beansgum pushed a commit to beansgum/dcrwallet that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants