chain: Wait for dcrd to sync before starting RPC sync #2340
Conversation
|
I don't think this is the right way we want to fix this. The big issue for us is with address discovery. We don't want to have dcrwallet to begin syncing to a dcrd that is not synced with the network, as it may not find all addresses for the rescan. However, before that point, it is perfectly fine to sync headers as long as we are not increasing the block that we have marked synced transactions with. Waiting for an out-of-date dcrd to catch up to the wallet, but perhaps not necessarily the network, will still trigger the address discovery issue. dcrd has a pretty good idea about when it is "current" or not. We should probably look at a way to plumb that information to dcrwallet, while syncing only headers before that point. |
That's the I intentionally did not take that into account here because it has a "blocks are less than 2 hours old" heuristic to consider itself synced when there are no peers, and I thought that would conflict with offline wallet scenarios, but I can add that as an additional check in Ideally, we'd have a |
|
Pushed the change which makes it track dcrd's But as I mentioned, this makes offline wallets keep looping in the "wainting dcrd sync" stage. I could add a special case to disregard the IBS flag when What do you think? |
|
A --nosync or --offline or similar would be best. Otherwise even if everything else works properly, we'd be endlessly spamming failed connection attempts in the log. |
|
Ok, will work on adding |
This prevents the wallet from syncing from blockConnected messages when it is connected to a dcrd instance that is not yet as synced as the one the wallet has used in the past. This improves performance by batching the sync work in the initial getHeaders stage and prevents wallet misuse by ensuring the underlying dcrd is also synced to recent blocks. Note that the the case of a new wallet (with recorded tip height 0) connected to a network isolated dcrd instance (header and block height both 0) is explicitly allowed to proceed without waiting. This handles the use-cases of airgapped and empty simnet wallets.
|
Updated with commit to add |
This adds the --offline sync mode to the wallet. This mode allows the wallet to run without connecting to the network through either SPV or RPC modes. Calls that do not require access to the network can still be executed. This is mostly useful for running wallets which are meant only to generate addresses and sign transactions without actually tracking balances, such as air-gapped wallets. Previously, such wallets required running with an unconnected dcrd instance or in SPV mode with --spvconnect specified to an address that would not provide network services, but these methods are prone to be misused and recent changes have broken their correct behavior. The offline mode is introduced by writing a custom NetworkBackend implementation that is guaranteed to never attempt any external connections.
|
Fixed commit message. |
This prevents the wallet from syncing from blockConnected messages when it is connected to a dcrd instance that is not yet as synced as the one the wallet has used in the past. This improves performance by batching the sync work in the initial getHeaders stage and prevents wallet misuse by ensuring the underlying dcrd is also synced to recent blocks.
Note that the the case of a new wallet (with recorded tip height 0) connected to a network isolated dcrd instance (header and block height both 0) is explicitly allowed to proceed without waiting. This handles the use-cases of airgapped and empty simnet wallets.