Fix a bug in the semver compatibility check. #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a fix in dcrrpcclient first before this will work correctly. |
While here, improve the error returned by RPCClient.Connect to include both the required and advertised API versions. These versions are independent of the program and/or project's release versions, but it should still be useful in determining whether dcrd must be downgraded or upgraded for compatibility with this wallet software. Add a 30 second sleep after any connection or compatibility errors (where compatibility errors are not just incorrect API versions, but mismatched currency networks as well). This prevents an immediate reconnect to the server. Fixes btcsuite#379.
|
Works now. OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While here, improve the error returned by RPCClient.Connect to include
both the required and advertised API versions. These versions are
independent of the program and/or project's release versions, but it
should still be useful in determining whether dcrd must be downgraded
or upgraded for compatibility with this wallet software.
Add a 30 second sleep after any connection or compatibility errors
(where compatibility errors are not just incorrect API versions, but
mismatched currency networks as well). This prevents an immediate
reconnect to the server.
Fixes #379.