Fix a bug in the semver compatibility check. #380

Merged
merged 1 commit into from Nov 10, 2016

Projects

None yet

2 participants

@jrick
Member
jrick commented Nov 10, 2016

While here, improve the error returned by RPCClient.Connect to include
both the required and advertised API versions. These versions are
independent of the program and/or project's release versions, but it
should still be useful in determining whether dcrd must be downgraded
or upgraded for compatibility with this wallet software.

Add a 30 second sleep after any connection or compatibility errors
(where compatibility errors are not just incorrect API versions, but
mismatched currency networks as well). This prevents an immediate
reconnect to the server.

Fixes #379.

@jrick
Member
jrick commented Nov 10, 2016

Needs a fix in dcrrpcclient first before this will work correctly.

@jrick jrick Fix a bug in the semver compatibility check.
While here, improve the error returned by RPCClient.Connect to include
both the required and advertised API versions.  These versions are
independent of the program and/or project's release versions, but it
should still be useful in determining whether dcrd must be downgraded
or upgraded for compatibility with this wallet software.

Add a 30 second sleep after any connection or compatibility errors
(where compatibility errors are not just incorrect API versions, but
mismatched currency networks as well).  This prevents an immediate
reconnect to the server.

Fixes #379.
58a8922
@jcvernaleo
Member

Works now. OK

@jcvernaleo

OK

@jrick jrick merged commit dba252e into decred:master Nov 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jrick jrick deleted the jrick:apiversionerr branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment