Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return block height for vspds #142

Closed
xaur opened this issue May 26, 2021 · 4 comments · Fixed by #167
Closed

Return block height for vspds #142

xaur opened this issue May 26, 2021 · 4 comments · Fixed by #167

Comments

@xaur
Copy link

xaur commented May 26, 2021

It would be good to have https://api.decred.org/?c=vsp return block heights just like it was added in #137.

Knowing height is very useful to see which VSPs are not syncing properly, and getting all this data from ?c=vsp is much faster and easier than polling each VSP. I guess it could even be used by dcrwallet/Decrediton as a quick sanity check when suggesting a VSP to the user.

With decred/vspd#254 merged, height info should be available when polling vspds (for those that have upgraded). As of writing I'm not seeing any mainnet vspds returning blockheight but this testnet one can be used for testing:

https://testnet-vsp.jholdstock.uk/api/v3/vspinfo

@jholdstock
Copy link
Member

Can also consider adding proportion live

@jholdstock
Copy link
Member

Required vspd PRs are decred/vspd#264 and decred/vspd#254. Both will be included in the next release of vspd, and then we can implement this issue.

@xaur
Copy link
Author

xaur commented Aug 5, 2022

I encountered a case where block height in ?c=vsp response would be really handy.

For dcrpool.ibitlin.com this endpoint and the VSP page show 55 live tickets and a very fresh Last Updated timestamp. So for the end users it looks good and safe to use, but it's not the case. Thanks to decred/vspd#254 , we can see that it got stuck at block 666669 (Jun 10), its ticket stats are not changing since then, still it gives a fresh timestamp on each request. So end users cannot rely on Last Updated alone, I think they need to see the block height on the VSP page.

Ideally, VSP clients like dcrwallet and Decrediton would check block height and warn the user if it's too old.

@amass01
Copy link
Member

amass01 commented Sep 9, 2022

would like to work on it 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants