Remove unused gcs and dc endpoints. #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only known caller of the coin supply and download count endpoints was JavaScript running on decred.org. Since the site overhaul, these endpoints are not used. Further justifying their removal is the fact that coin supply is readily available from dcrdata API, and the download count was a very rough estimate based on a quite basic heuristic.
dajohi
approved these changes
Sep 29, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only known caller of the coin supply and download count endpoints was JavaScript running on decred.org. Since the site overhaul (decred/dcrweb#1056), these endpoints are no longer used.
Further justifying their removal is the fact that coin supply is readily available from dcrdata API, and the download count was only a very rough estimate based on a quite basic heuristic.