Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Add Ledger support. #3865

Closed
3 of 6 tasks
JoeGruffins opened this issue Apr 27, 2023 · 7 comments · Fixed by #3906
Closed
3 of 6 tasks

multi: Add Ledger support. #3865

JoeGruffins opened this issue Apr 27, 2023 · 7 comments · Fixed by #3906

Comments

@JoeGruffins
Copy link
Member

JoeGruffins commented Apr 27, 2023

As approved in the proposal we are adding ledger support to decrediton. This issue is intended to track those changes.

The goal is to have the ability to sign and send transactions, receive transactions, view transaction history and verify addresses associated with the Ledger in a new scene based heavily off of the current trezor flow.

Changes will be made in small increments with as many tests as possible. I would like to disable mainnet use until everything is well tested and refined.

One thing I am not sure of is a small ledger icon we will need to use. If anyone reading this can produce one without much effort please let me know.

TODO:

  • add ledger backend methods
  • remove tickets section from trezor and add warning to obtaining address screen about only using in p2pkh scripts.
  • add new screens for ledger and hook those up to the ledger methods
  • create the small ledger icon on the create/choose wallet page
  • finalize (testing/debugging) and allow on mainnet
  • make tests for LedgerActions.js methods using a device and the testnet decred app (time/funding permitting)
change log
2023-04-28 Add TODO checklist
2023-09-21 Check add ledger backend methods, create small ledger icon, and remove tickets section
@JoeGruffins
Copy link
Member Author

I am currently adding a LedgerActions.js file in actions and a file in helpers that should work as a good base and hold all of the logic from the poc we intend to use.

@amass01
Copy link
Member

amass01 commented May 2, 2023

we should an TODO for adding the icon.

@JoeGruffins
Copy link
Member Author

we should an TODO for adding the icon.

Do you mean use a placeholder for now?

@amass01
Copy link
Member

amass01 commented May 4, 2023

no i mean a todo here in this issue tasks list, but i see now it's already there

@JoeGruffins
Copy link
Member Author

Ok! I have started on remove tickets section from trezor and add warning to obtaining address screen about only using in p2pkh scripts.

@amass01
Copy link
Member

amass01 commented May 5, 2023

Sweet, I also started Create the small ledger icon on the create/choose wallet page, not that the icon is also
used in the main screen.

@JoeGruffins
Copy link
Member Author

I don't guess we will have time to add the tests using a device. Hopefully can get the rest merged here soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants