Remove util type checks #3135
Merged
Remove util type checks #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
suggested changes
Jan 9, 2021
app/actions/StatisticsActions.js
Outdated
| @@ -391,7 +390,7 @@ export const exportStatToCSV = (opts) => (dispatch, getState) => { | |||
| // called once for each data line | |||
| const progressFunction = (time, series) => { | |||
| const values = allSeries.map((s) => | |||
| !isUndefined(series[s.name]) ? s.valueFormatFunc(series[s.name]) : null | |||
| series[s.name] !== undefined ? s.valueFormatFunc(series[s.name]) : null | |||
There was a problem hiding this comment.
This isn't enough, you could also check if typeof x === "undefined" but I would rather use lodash isUndefined func for that.
Lodash may have it's own version of isNumber, isNullOrUndefined funcs as well, checkout their documentation.
guilhermemntt
force-pushed
the
guilhermemntt-remove-util-type-checks
branch
from
133af32
to
76ed888
Compare
|
Thanks @amassarwi, you're totally right. Just to be clearer: |
|
needs rebase |
guilhermemntt
force-pushed
the
guilhermemntt-remove-util-type-checks
branch
from
76ed888
to
fcbdd88
Compare
|
Rebased. |
|
Quite a few conflicts that will need to be dealt with. |
guilhermemntt
force-pushed
the
guilhermemntt-remove-util-type-checks
branch
from
fcbdd88
to
6ad7791
Compare
alexlyp
pushed a commit
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3131.